feat(credentials): add stage 2 centralized broker and refresh fencing
Add an internal CredentialBroker that serializes refresh and authorization by environment/app/user using renewable Redis leases. Re-read credentials under the lease and persist rotated pairs with expected-version CAS before returning an explicit access-only grant. Verify the actual platform user, remaining lifetime and scopes; never return refresh tokens from the broker. Persist source-version refresh attempts before platform calls. Timeouts, cancellation, lease loss, malformed responses and ambiguous database errors fence reuse of the old rotating refresh token, including after restart. A new authorization can establish a new version without stale overwrite. Add a strict, separate private Work v1 OIDC adapter while preserving legacy OAuth method behavior. Enable fakeredis Lua test support for Redis lease renewal tests. Document stage boundaries, recovery limitations and testing. Validation: 147 passed, 2 skipped (real PostgreSQL not configured), with 15 existing uvicorn/websockets deprecation warnings. New broker/adapter coverage: 45 tests. AST, runtime opt-in boundary and diff checks pass. An earlier Windows temp-file replace failure in a legacy client test passed both isolated rerun and the final full suite; no client code was changed. No public credential/OAuth routes are wired, no production database/key is initialized, and no real Work authorization, refresh or ECS deployment was performed. Authenticated access-token issuance, state transactions, binding checks and unbind integration remain subsequent stages.
This commit is contained in:
@@ -208,6 +208,12 @@ def test_postgres_encryption_cas_and_schema_reentry(tmp_path):
|
||||
with pytest.raises(CredentialConflict):
|
||||
vault.save("test", "app", "alice", expected_version=1, **payload("stale"))
|
||||
assert vault.get("test", "app", "alice").refresh_token == "test-refresh-new"
|
||||
assert vault.begin_refresh("test", "app", "alice", 2, "pg-attempt")
|
||||
assert not vault.begin_refresh("test", "app", "alice", 2, "pg-duplicate")
|
||||
assert vault.refresh_status("test", "app", "alice", 2) == "started"
|
||||
assert vault.finish_refresh("test", "app", "alice", 2, "pg-attempt", "unknown")
|
||||
assert not vault.finish_refresh("test", "app", "alice", 2, "pg-attempt", "completed")
|
||||
assert vault.refresh_status("test", "app", "alice", 2) == "unknown"
|
||||
row = store.db.execute("SELECT ciphertext FROM work_credentials_v2").fetchone()
|
||||
assert "test-refresh" not in row["ciphertext"]
|
||||
finally:
|
||||
|
||||
Reference in New Issue
Block a user