fix(work): return approval state cards directly from callbacks

This commit is contained in:
ex_tianzy
2026-11-18 10:00:55 +08:00
parent 7d2a15eaba
commit 61db139c72
11 changed files with 165 additions and 25 deletions
@@ -0,0 +1,60 @@
import json
import pytest
from test_credential_api import env
from test_approval_integration import approval_env, pair, pc_errors
from relay.approval_cards import decision_response_card
from relay.longconn import safe_card_callback_response
@pytest.mark.parametrize(('choice','state'),[('deny','rejected'),('allow','approved')])
async def test_callback_returns_no_button_terminal_card_to_clicked_view(pair,choice,state):
p=pair
job=p['launch']()
response,_=await p['click'](choice)
assert response.status_code==200
payload=response.json()
assert payload['toast']['type']=='info'
forwarded=safe_card_callback_response(payload)
assert forwarded['card']==payload['card']
assert forwarded['card']=={'type':'raw','data':decision_response_card(state)}
card=forwarded['card']['data']
assert card['config']['update_multi'] is True
assert '"button"' not in json.dumps(card)
if choice=='deny':
with pytest.raises(pc_errors.ApprovalRejected):await job
assert not p['calls']
else:
assert (await job)['status']=='completed'
assert len(p['calls'])==1
def test_callback_proxy_discards_untrusted_card_payload():
result=safe_card_callback_response({'toast':{'type':'info','content':'ok'},
'card':{'type':'raw','data':{'secret':'do-not-forward'}}})
assert result=={'toast':{'type':'warning','content':'确认结果待核对,请查看任务状态。'}}
assert 'do-not-forward' not in json.dumps(result)
async def test_explicit_refresh_repairs_a_known_closed_card_without_new_message(pair):
p=pair
job=p['launch']();row=await p['card']();await p['click']('deny')
with pytest.raises(pc_errors.ApprovalRejected):await job
e=p['env'];sender=e['app'].state.approvals.sender
await sender.update_closed(row['approval_id'])
assert await sender.update_closed(row['approval_id'])=={'state':'no_closed_card'}
assert await sender.update_closed(row['approval_id'],refresh=True)=={'state':'updated'}
assert len(e['platform'].cards)==1
assert e['store'].db.execute('SELECT state FROM work_approvals_v3').fetchone()['state']=='rejected'
assert not p['calls']
async def test_admin_repair_preview_is_scoped_and_never_sends_card(pair):
p=pair
job=p['launch']();row=await p['card']();await p['click']('deny')
with pytest.raises(pc_errors.ApprovalRejected):await job
api=p['env']['app'].state.approvals
before=len(p['env']['platform'].cards)
ids=await api.worker.call('closed_for_task',p['context']['task_id'])
assert ids==[row['approval_id']]
assert len(p['env']['platform'].cards)==before