fix(work): fence repeated approval intents and audit state changes atomically
This commit is contained in:
@@ -0,0 +1,119 @@
|
||||
"""M6 audit and cleanup on temporary encrypted approval stores only."""
|
||||
import json
|
||||
import pytest
|
||||
from test_credential_api import env
|
||||
from test_approval_integration import approval_env,pair
|
||||
from relay.approval_store import ApprovalStore,ApprovalError
|
||||
|
||||
|
||||
async def test_audit_is_minimal_and_repeated_decisions_do_not_duplicate(pair):
|
||||
p=pair;job=p['launch']();row=await p['card']();response,body=await p['click']()
|
||||
await job
|
||||
e=p['env'];await e['client'].post('/internal/approval-callback',json=body,
|
||||
headers={'X-Internal-Secret':e['settings'].internal_secret})
|
||||
events=[dict(r)for r in e['store'].db.execute('SELECT * FROM work_approval_audit_v1').fetchall()]
|
||||
assert {r['event']for r in events}>={'created','card_bound','approved','consumed'}
|
||||
assert sum(r['event']=='approved'for r in events)==1
|
||||
assert sum(r['event']=='consumed'for r in events)==1
|
||||
encoded=json.dumps(events)
|
||||
for secret in ('ou_a','oc_synthetic','om_source','合成测试','fake-access','verification-synthetic',row['ciphertext']):
|
||||
assert secret not in encoded
|
||||
assert all(len(r['actor_scope'])==64 and len(r['device_scope'])==64 for r in events)
|
||||
assert all(r['action_class']=='work_api_write'for r in events)
|
||||
|
||||
|
||||
async def test_closed_payload_purge_keeps_replay_tombstone_and_active_payload(pair):
|
||||
p=pair;job=p['launch']();row=await p['card']();await p['click']('deny')
|
||||
from test_approval_integration import pc_errors
|
||||
with pytest.raises(pc_errors.WorkError):await job
|
||||
e=p['env'];now=__import__('time').time()
|
||||
with e['store'].db:e['store'].db.execute('UPDATE work_approvals_v3 SET updated_at=?',(now-31*86400,))
|
||||
api=ApprovalStore(e['store'].lifecycle,e['api'].broker.store.keyring,clock=lambda:now)
|
||||
active=api.create('task-approval','ou_a','a'*32,1,'operation-active',{'kind':'synthetic'},'合成动作','仅测试')
|
||||
with e['store'].db:e['store'].db.execute('UPDATE work_approvals_v3 SET updated_at=? WHERE approval_id=?',
|
||||
(now-32*86400,active['approval_id']))
|
||||
result=api.maintain_retention()
|
||||
assert result['payloads_purged']==1 and result['tombstones_preserved']
|
||||
saved=e['store'].db.execute('SELECT * FROM work_approvals_v3').fetchone()
|
||||
assert saved['state']=='rejected'and saved['ciphertext']==''and saved['nonce_digest']==''
|
||||
assert api.maintain_retention()['payloads_purged']==0
|
||||
status=api.status(row['approval_id'],'task-approval','ou_a','a'*32,1,row['operation_digest'])
|
||||
assert status['state']=='rejected'
|
||||
assert api.consume(row['approval_id'],'task-approval','ou_a','a'*32,1,row['operation_digest'])['execute']is False
|
||||
action=json.loads(e['api'].broker.store.keyring.decrypt(row['key_id'],row['ciphertext'],api._aad(row)))['action']
|
||||
assert api.create('task-approval','ou_a','a'*32,1,'operation-synthetic',action,'同动作','不得重新放行')['state']=='rejected'
|
||||
# A pre-existing pending approval is not selected even when timestamp is old.
|
||||
assert api.maintain_retention()['payloads_purged']==0
|
||||
assert e['store'].db.execute('SELECT ciphertext FROM work_approvals_v3 WHERE approval_id=?',
|
||||
(active['approval_id'],)).fetchone()['ciphertext']
|
||||
|
||||
|
||||
async def test_retention_is_environment_scoped_and_bounded(pair):
|
||||
p=pair;job=p['launch']();row=await p['card']();await p['click']('deny')
|
||||
from test_approval_integration import pc_errors
|
||||
with pytest.raises(pc_errors.WorkError):await job
|
||||
e=p['env'];now=__import__('time').time()
|
||||
api=ApprovalStore(e['store'].lifecycle,e['api'].broker.store.keyring,clock=lambda:now)
|
||||
with e['store'].db:
|
||||
e['store'].db.execute('UPDATE work_approvals_v3 SET updated_at=?',(now-100*86400,))
|
||||
e['store'].db.execute('UPDATE work_approval_audit_v1 SET created_at=?',(now-100*86400,))
|
||||
result=api.maintain_retention(limit=1)
|
||||
assert result['audit_events_removed']==1
|
||||
assert e['store'].db.execute('SELECT COUNT(*) n FROM work_approvals_v3').fetchone()['n']==1
|
||||
assert e['store'].db.execute('SELECT COUNT(*) n FROM work_approval_callbacks_v1').fetchone()['n']==1
|
||||
for kwargs in ({'payload_days':0},{'audit_days':366},{'payload_days':91,'audit_days':90},{'limit':100}):
|
||||
with pytest.raises(ApprovalError):api.maintain_retention(**kwargs)
|
||||
|
||||
|
||||
async def test_audit_write_failure_rolls_back_consume_and_never_sends(pair,monkeypatch):
|
||||
from relay.approval_audit import ApprovalAudit
|
||||
from test_approval_integration import pc_errors
|
||||
original=ApprovalAudit.record
|
||||
def fail_consume(self,row,event,action_class=None):
|
||||
if event=='consumed':raise RuntimeError('synthetic audit storage failure')
|
||||
return original(self,row,event,action_class)
|
||||
monkeypatch.setattr(ApprovalAudit,'record',fail_consume)
|
||||
p=pair;job=p['launch']();await p['click']()
|
||||
with pytest.raises(pc_errors.WorkError):await job
|
||||
e=p['env']
|
||||
assert not p['calls']
|
||||
assert e['store'].db.execute("SELECT state FROM work_approvals_v3").fetchone()['state']!='consumed'
|
||||
assert not e['store'].db.execute("SELECT * FROM work_approval_audit_v1 WHERE event='consumed'").fetchall()
|
||||
|
||||
|
||||
async def test_retention_never_touches_another_environment(pair):
|
||||
from test_approval_integration import pc_errors
|
||||
p=pair;job=p['launch']();await p['click']('deny')
|
||||
with pytest.raises(pc_errors.WorkError):await job
|
||||
e=p['env'];now=__import__('time').time()
|
||||
with e['store'].db:e['store'].db.execute("UPDATE work_approvals_v3 SET environment='development',updated_at=?",(now-100*86400,))
|
||||
api=ApprovalStore(e['store'].lifecycle,e['api'].broker.store.keyring,clock=lambda:now)
|
||||
assert api.maintain_retention()['payloads_purged']==0
|
||||
assert e['store'].db.execute('SELECT ciphertext FROM work_approvals_v3').fetchone()['ciphertext']
|
||||
|
||||
|
||||
def test_retention_configuration_is_explicit_and_ordered():
|
||||
from relay.config import Settings
|
||||
from pydantic import ValidationError
|
||||
settings=Settings(role='test',environment='test')
|
||||
assert settings.approval_retention_enabled is False
|
||||
assert (settings.approval_payload_retention_days,settings.approval_audit_retention_days)==(30,90)
|
||||
for changes in ({'approval_retention_enabled':True},
|
||||
{'approval_payload_retention_days':91,'approval_audit_retention_days':90},
|
||||
{'approval_audit_retention_days':366}):
|
||||
with pytest.raises(ValidationError):Settings(role='test',environment='test',**changes)
|
||||
|
||||
|
||||
async def test_consumed_but_result_unknown_is_not_purged(pair):
|
||||
p=pair;job=p['launch']();await p['click']();await job
|
||||
e=p['env'];now=__import__('time').time()
|
||||
api=ApprovalStore(e['store'].lifecycle,e['api'].broker.store.keyring,clock=lambda:now)
|
||||
with e['store'].db:
|
||||
e['store'].db.execute('UPDATE work_approvals_v3 SET updated_at=?',(now-100*86400,))
|
||||
e['store'].db.execute("UPDATE work_tasks_v2 SET status='unknown'")
|
||||
assert api.maintain_retention()['payloads_purged']==0
|
||||
assert e['store'].db.execute('SELECT ciphertext FROM work_approvals_v3').fetchone()['ciphertext']
|
||||
with e['store'].db:e['store'].db.execute("UPDATE work_tasks_v2 SET status='completed'")
|
||||
# Bounded keyset scan wraps on the next maintenance pass.
|
||||
outcomes=[api.maintain_retention()['payloads_purged']for _ in range(2)]
|
||||
assert sum(outcomes)==1
|
||||
Reference in New Issue
Block a user